Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10540040: Inline setters, getters, various cleanups & restructuring. (Closed)

Created:
8 years, 6 months ago by srdjan
Modified:
8 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Inline setters, getters, various cleanups & restructuring. TODO: cid, token_index and try_index are often passsed around. We should pack them in a data structure. Committed: https://code.google.com/p/dart/source/detail?r=8406

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 10

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -63 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 3 4 5 3 chunks +43 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.h View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 2 3 4 5 1 chunk +24 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.h View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 3 4 5 1 chunk +24 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 3 4 5 6 2 chunks +146 lines, -3 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 2 3 4 5 2 chunks +17 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 3 4 5 4 chunks +28 lines, -11 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 4 5 4 chunks +45 lines, -27 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 3 4 5 6 7 4 chunks +18 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 3 4 5 6 7 5 chunks +18 lines, -7 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/object_test.cc View 1 2 3 4 5 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
8 years, 6 months ago (2012-06-07 00:21:43 UTC) #1
Florian Schneider
LGTM. https://chromiumcodereview.appspot.com/10540040/diff/13001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://chromiumcodereview.appspot.com/10540040/diff/13001/runtime/vm/flow_graph_optimizer.cc#newcode253 runtime/vm/flow_graph_optimizer.cc:253: // TODO(srdjan): Inline special getters (e.g., array length). ...
8 years, 6 months ago (2012-06-07 08:47:59 UTC) #2
srdjan
8 years, 6 months ago (2012-06-07 18:24:50 UTC) #3 
https://chromiumcodereview.appspot.com/10540040/diff/13001/runtime/vm/flow_gr...
File runtime/vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10540040/diff/13001/runtime/vm/flow_gr...
runtime/vm/flow_graph_optimizer.cc:253: // TODO(srdjan): Inline special getters
(e.g., array length).
On 2012/06/07 08:47:59, Florian Schneider wrote:
> s/getter/setter/

Done.

https://chromiumcodereview.appspot.com/10540040/diff/13001/runtime/vm/flow_gr...
runtime/vm/flow_graph_optimizer.cc:265: // Replace 'comp' with 'load'.
On 2012/06/07 08:47:59, Florian Schneider wrote:
> s/load/store/

Done.

https://chromiumcodereview.appspot.com/10540040/diff/13001/runtime/vm/interme...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/10540040/diff/13001/runtime/vm/interme...
runtime/vm/intermediate_language.cc:675: // Use 'result' as temporary register.
On 2012/06/07 08:47:59, Florian Schneider wrote:
> Comment seems out of date: There is no 'result' register anymore.

Done.

https://chromiumcodereview.appspot.com/10540040/diff/13001/runtime/vm/interme...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10540040/diff/13001/runtime/vm/interme...
runtime/vm/intermediate_language.h:688: // If non-NULL, the instruction is valid
only for the clas ids listed.
On 2012/06/07 08:47:59, Florian Schneider wrote:
> s/clas/class/

Done.

https://chromiumcodereview.appspot.com/10540040/diff/13001/runtime/vm/interme...
runtime/vm/intermediate_language.h:724: // If non-NULL, the instruction is valid
only for the clas ids listed.
On 2012/06/07 08:47:59, Florian Schneider wrote:
> s/clas/class/

Done.

Powered by Google App Engine
This is Rietveld 408576698