Issue 10540036: add a note about completer to future

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10540036: add a note about completer to future (Closed)

Created:
8 years, 6 months ago by sethladd

Modified:
8 years, 6 months ago

Reviewers:
Bill Hesse, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

add a note about completer to future BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8366

Patch Set 2 : tweaks from review #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	corelib/src/future.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://chromiumcodereview.appspot.com/10540036/diff/1/corelib/src/future.dart File corelib/src/future.dart (right): https://chromiumcodereview.appspot.com/10540036/diff/1/corelib/src/future.dart#newcode32 corelib/src/future.dart:32: * Use a [Completer] to simplify working with futures. ...

8 years, 6 months ago (2012-06-06 22:28:43 UTC) #2

LGTM.  Great!

Expand Messages | Collapse Messages

Issue 10540036: add a note about completer to future (Closed)

Description

Patch Set 1 #

Patch Set 2 : tweaks from review #

Messages