Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 10540029: Adds a warning if the + opearator is used with two strings. (Closed)

Created:
8 years, 6 months ago by zundel
Modified:
8 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adds a warning if the + opearator is used with two strings. http://code.google.com/p/dart/issues/detail?id=2549 Committed: https://code.google.com/p/dart/source/detail?r=8350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -16 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 3 chunks +24 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java View 5 chunks +40 lines, -13 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java View 2 chunks +8 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeTestCase.java View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
8 years, 6 months ago (2012-06-06 15:42:28 UTC) #1
scheglov
8 years, 6 months ago (2012-06-06 15:56:39 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698