Issue 10540016: indexedDB work

Issue 10540016: indexedDB work (Closed)

Created:
8 years, 6 months ago by sra1

Modified:
8 years, 6 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, Anton Muhin, podivilov1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

indexedDB work Make string 'mode' argument to IDBDatabase.transaction work on older browsers. Make window.indexedDB available. Does not yet work of Firefox for other reasons. Add interface IDBOpenDBRequest. IDBFactory.open returns this in the most recent spec, and is implemented by Firefox. Next, I will try to use the new event kinds on IDBOpenDBRequest to get Firefox to open a database. Committed: https://code.google.com/p/dart/source/detail?r=8369

Patch Set 1 : #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+270 lines, -32 lines)			Patch
M	lib/dom/dom.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/dom/idl/dart/dart.idl	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	lib/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/dom/templates/html/dartium/html_dartium.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/dom/templates/html/dartium/impl_Window.darttemplate	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/dom/templates/html/frog/html_frog.darttemplate	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	lib/dom/templates/html/frog/impl_IDBDatabase.darttemplate	View	1 chunk	+49 lines, -0 lines	1 comment	Download
M	lib/dom/templates/html/frog/impl_Window.darttemplate	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	lib/dom/templates/html/interface/interface_Window.darttemplate	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	6 chunks	+28 lines, -12 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View	7 chunks	+104 lines, -3 lines	0 comments	Download
A	lib/html/src/IDBOpenDBRequest.dart	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A	lib/html/src/frog_IDBOpenDBRequestImplementation.dart	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/html/indexeddb_1_test.dart	View	6 chunks	+6 lines, -7 lines	0 comments	Download
M	tests/html/indexeddb_2_test.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/html/indexeddb_3_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/indexeddb_4_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 6 months ago (2012-06-06 20:08:47 UTC) #2

LGTM

We should experiment with some sort of enum pattern though.

https://chromiumcodereview.appspot.com/10540016/diff/4001/lib/dom/templates/h...
File lib/dom/templates/html/frog/impl_IDBDatabase.darttemplate (right):

https://chromiumcodereview.appspot.com/10540016/diff/4001/lib/dom/templates/h...
lib/dom/templates/html/frog/impl_IDBDatabase.darttemplate:8: if (mode !=
'readonly' && mode != 'readwrite') {
Consider pushing to into _transaction_*_mode to eliminate the partially
redundant check there.  Up to you though.

Expand Messages | Collapse Messages