Issue 10539164: Text run together in JSON docs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10539164: Text run together in JSON docs (Closed)

Created:
8 years, 6 months ago by eub

Modified:
7 years, 2 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org, samhop

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Text run together in JSON docs

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
	M	lib/json/json_frog.dart	View		3 chunks	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eub

Hi, Bob, is this the correct syntax for unordered lists? (How does dartdoc choose to ...

8 years, 6 months ago (2012-06-14 18:01:05 UTC) #1

Bob Nystrom

8 years, 6 months ago (2012-06-14 20:33:53 UTC) #2

LGTM!

On 2012/06/14 18:01:05, eub wrote:
> Hi, Bob, is this the correct syntax for unordered lists?

Yup!

> 
> (How does dartdoc choose to show docs for json_frog.dart, shadowing
json.dart?)

Dartdoc uses whatever libraries frog chooses to load when you ask for
"dart:whatever". Once dartdoc is moved over to dart2js, that should go away.

> 
> Yeah, I know frog has a short TTL, just want to clean this up so we don't copy
> bad formatting over to the new docs.

Good call!

- bob

Expand Messages | Collapse Messages