Issue 10539145: Implement polymorphic instance calls.

Issue 10539145: Implement polymorphic instance calls. (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement polymorphic instance calls. Committed: https://code.google.com/p/dart/source/detail?r=8678

Patch Set 6 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -27 lines)			Patch
M	runtime/vm/code_generator.h	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2 3	2 chunks	+3 lines, -20 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4	1 chunk	+49 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4	1 chunk	+48 lines, -0 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://chromiumcodereview.appspot.com/10539145/diff/9002/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://chromiumcodereview.appspot.com/10539145/diff/9002/runtime/vm/intermediate_language_ia32.cc#newcode1603 runtime/vm/intermediate_language_ia32.cc:1603: __ movl(EAX, Please add a comment like: // ...

8 years, 6 months ago (2012-06-14 11:22:03 UTC) #2

srdjan

8 years, 6 months ago (2012-06-14 17:47:15 UTC) #3

https://chromiumcodereview.appspot.com/10539145/diff/9002/runtime/vm/intermed...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10539145/diff/9002/runtime/vm/intermed...
runtime/vm/intermediate_language_ia32.cc:1603: __ movl(EAX,
On 2012/06/14 11:22:03, Vyacheslav Egorov (Google) wrote:
> Please add a comment like:
> 
> // Load receiver into EAX. 
> 
> (same on x64)

Done.

https://chromiumcodereview.appspot.com/10539145/diff/9002/runtime/vm/intermed...
runtime/vm/intermediate_language_ia32.cc:1606: __ j(ZERO, is_smi_label);  // Smi
-> deopt.
On 2012/06/14 11:22:03, Vyacheslav Egorov (Google) wrote:
> Comment does not match the code.
> 
> (same on x64)

Done.

Expand Messages | Collapse Messages