Issue 10539068: Add righ shift test for corner cases, use macro for deopt reasons (all suggested by Slava in a prev…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10539068: Add righ shift test for corner cases, use macro for deopt reasons (all suggested by Slava in a prev… (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add righ shift test for corner cases, use macro for deopt reasons (all suggested by Slava in a previous CL) Committed: https://code.google.com/p/dart/source/detail?r=8459

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -62 lines)			Patch
M	runtime/vm/code_generator.h	View		1 chunk	+33 lines, -28 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1	1 chunk	+3 lines, -34 lines	0 comments	Download
M	tests/language/bit_operations_test.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://chromiumcodereview.appspot.com/10539068/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://chromiumcodereview.appspot.com/10539068/diff/1/runtime/vm/code_generator.cc#newcode1399 runtime/vm/code_generator.cc:1399: #define DEOPT_REASON_ID_TO_TEXT(name) case k##name: return ""#name; why do ...

8 years, 6 months ago (2012-06-08 17:44:19 UTC) #2

srdjan

8 years, 6 months ago (2012-06-08 18:09:52 UTC) #3

https://chromiumcodereview.appspot.com/10539068/diff/1/runtime/vm/code_genera...
File runtime/vm/code_generator.cc (right):

https://chromiumcodereview.appspot.com/10539068/diff/1/runtime/vm/code_genera...
runtime/vm/code_generator.cc:1399: #define DEOPT_REASON_ID_TO_TEXT(name) case
k##name: return ""#name;
On 2012/06/08 17:44:19, Vyacheslav Egorov (Google) wrote:
> why do we need empty string literal?

Removed. I thought it was required to force #name to be string.

Expand Messages | Collapse Messages

Issue 10539068: Add righ shift test for corner cases, use macro for deopt reasons (all suggested by Slava in a prev… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages