Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 10539029: Fixed a mismatch describer with unreachable code. (Closed)

Created:
8 years, 6 months ago by gram
Modified:
8 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixed a mismatch describer with unreachable code. Commented out isInstance tests that are causing issues with dart2js. Committed: https://code.google.com/p/dart/source/detail?r=8368

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M lib/unittest/map_matchers.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/utils/unittest_test.dart View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
PTAL
8 years, 6 months ago (2012-06-06 22:44:18 UTC) #1
gram
8 years, 6 months ago (2012-06-06 22:49:22 UTC) #2
Siggi Cherem (dart-lang)
8 years, 6 months ago (2012-06-06 23:00:37 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698