Issue 10538090: Fix typo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10538090: Fix typo. (Closed)

Created:
8 years, 6 months ago by ngeoffray

Modified:
8 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix typo. Committed: https://code.google.com/p/dart/source/detail?r=8523

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	lib/compiler/implementation/lib/interceptors.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	tests/language/is_nan_test.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM, even though I'm not sure you'll see a NoSuchMethodException consistently across all browsers.

8 years, 6 months ago (2012-06-12 04:46:36 UTC) #2

ngeoffray

On 2012/06/12 04:46:36, kasperl wrote: > LGTM, even though I'm not sure you'll see a ...

8 years, 6 months ago (2012-06-12 06:19:36 UTC) #3

ngeoffray

8 years, 6 months ago (2012-06-12 06:23:46 UTC) #4

On 2012/06/12 06:19:36, ngeoffray wrote:
> On 2012/06/12 04:46:36, kasperl wrote:
> > LGTM, even though I'm not sure you'll see a NoSuchMethodException
consistently
> > across all browsers.
> 
> True. I think I prefer having the test case valid

valid -> as-is

, and mark the test as failing
> on some browsers.  It should not be the only one failing on NoSuchMethod

Expand Messages | Collapse Messages