Issue 10538064: Implement inlined LoadIndexed operation for arrays on x64.

Issue 10538064: Implement inlined LoadIndexed operation for arrays on x64. (Closed)

Created:
8 years, 6 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement inlined LoadIndexed operation for arrays on x64. R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8462

Patch Set 1 #

Total comments: 4

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+196 lines, -9 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+7 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+38 lines, -0 lines	2 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+104 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10538064/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/10538064/diff/1/runtime/vm/intermediate_language.h#newcode793 runtime/vm/intermediate_language.h:793: receiver_type_(kIllegalObjectKind) { ASSERT array and index are not ...

8 years, 6 months ago (2012-06-08 19:16:08 UTC) #2

Vyacheslav Egorov (Google)

8 years, 6 months ago (2012-06-08 19:23:33 UTC) #3

thanks for the review! landing.

https://chromiumcodereview.appspot.com/10538064/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10538064/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:793: receiver_type_(kIllegalObjectKind) {
On 2012/06/08 19:16:08, srdjan wrote:
> ASSERT array and index are not NULL.

Done.

https://chromiumcodereview.appspot.com/10538064/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_x64.cc (right):

https://chromiumcodereview.appspot.com/10538064/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_x64.cc:334: receiver_type()));
On 2012/06/08 19:16:08, srdjan wrote:
> indent should be 4 spaces at each new line.

Done.

Expand Messages | Collapse Messages