Issue 10538024: Implemented missing instructions in ia32, more sharing, removed bailouts, enable optimiziations on …

Issue 10538024: Implemented missing instructions in ia32, more sharing, removed bailouts, enable optimiziations on … (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implemented missing instructions in ia32, more sharing, removed bailouts, enable optimiziations on ia32 with new compiler. Committed: https://code.google.com/p/dart/source/detail?r=8403

Patch Set 4 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+767 lines, -715 lines)			Patch
A	runtime/vm/flow_graph_compiler.cc	View	1 2 3	1 chunk	+367 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 2 3	3 chunks	+173 lines, -28 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3	5 chunks	+1 line, -59 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_shared.h	View	1 2 3	1 chunk	+0 lines, -198 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_shared.cc	View	1 2 3	1 chunk	+0 lines, -330 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2 3	4 chunks	+177 lines, -40 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	3 chunks	+1 line, -50 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3	3 chunks	+45 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

ia32 instructions LGTM. I have a suggestion for restructuring the platform-independent code in FlowGraphCompiler: https://chromiumcodereview.appspot.com/10538024/diff/8001/runtime/vm/flow_graph_compiler_shared.h ...

8 years, 6 months ago (2012-06-07 10:41:47 UTC) #3

srdjan

8 years, 6 months ago (2012-06-07 16:34:45 UTC) #4

https://chromiumcodereview.appspot.com/10538024/diff/8001/runtime/vm/flow_gra...
File runtime/vm/flow_graph_compiler_shared.h (right):

https://chromiumcodereview.appspot.com/10538024/diff/8001/runtime/vm/flow_gra...
runtime/vm/flow_graph_compiler_shared.h:157: virtual void
EmitInstructionPrologue(Instruction* instr) = 0;
On 2012/06/07 10:41:48, Florian Schneider wrote:
> Somehow it feels wrong to make those pure virtual just to share the code. How
> about the following structure to avoid having those pure virtual functions and
> also removing the extra super-class FlowGraphCompilerShared):
> 
> 1. Eliminate the class FlowGraphCompilerShared and the files
> flow_graph_compiler_shared{.h, .cc}.
> 2. Have plaform-specific .h file (flow_graph_compiler_xx.h) included from
> flow_graph_compiler.h (as is currently)
> 3. Implement the shared function in flow_graph_compiler.cc. The
compiler/linker
> will complain if one is missing.

Excellent idea, will do that and then submit.

Expand Messages | Collapse Messages