Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 10537077: Revert dart:io file InputStream buffering to fix bugs in it. Reverts r8435, r8401, r8396, r8395. (Closed)

Created:
8 years, 6 months ago by Bill Hesse
Modified:
8 years, 6 months ago
Reviewers:
ricow1, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert dart:io file InputStream buffering to fix bugs in it. Reverts r8435, r8401, r8396, r8395. BUG=dart:3450, dart:3434 TEST= Committed: https://code.google.com/p/dart/source/detail?r=8441

Patch Set 1 #

Patch Set 2 : Remove status file modification that was part of buffered input streams. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -142 lines) Patch
M runtime/bin/file_impl.dart View 13 chunks +56 lines, -98 lines 0 comments Download
M tests/standalone/io/file_test.dart View 2 chunks +30 lines, -44 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Hesse
8 years, 6 months ago (2012-06-08 14:29:56 UTC) #1
Ivan Posva
8 years, 6 months ago (2012-06-08 14:30:44 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698