Debugger break on TypeError, AssertionError

Debugger break on TypeError, AssertionError

Add debugger functionality to pause the VM whenever a TypeError
or AssertionError exception happens.

This is a first step towards breaking on handled and unhanded
exceptions in general. We first need to generate more debug info
for catch handlers so we can determine whether an exception will
be handled or not before we unwind the stack to run the catch
clauses.
Committed: https://code.google.com/p/dart/source/detail?r=8457

[siva, 2012-06-08 17:17:27]

lgtm

http://codereview.chromium.org/10537065/diff/9001/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

http://codereview.chromium.org/10537065/diff/9001/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:637: return class_name.Equals("TypeError") ||
class_name.Equals("AssertionError");
There may be a use case to treat these two separately, that is somebody wants to
stop only on type errors vs somebody who wants to stop on user introduced
assertions.

http://codereview.chromium.org/10537065/diff/9001/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

http://codereview.chromium.org/10537065/diff/9001/runtime/vm/exceptions.cc#ne...
runtime/vm/exceptions.cc:247: void Exceptions::Throw(const Instance& exception)
{
Isolate* isolate = Isolate::Current();
if (isolate-debugger()....) {
.....
}

http://codereview.chromium.org/10537065/diff/9001/runtime/vm/exceptions.cc#ne...
runtime/vm/exceptions.cc:252: ThrowExceptionHelper(exception,
Instance::Handle());
Instance::Handle(isolate);

http://codereview.chromium.org/10537065/diff/9001/tools/ddbg.dart
File tools/ddbg.dart (right):

http://codereview.chromium.org/10537065/diff/9001/tools/ddbg.dart#newcode99
tools/ddbg.dart:99: sendCmd(cmd).then((result) => handleSetBpResponse(result));
No command to be able to say
"stop on type errors"
"stop on assertion errors" etc.
or is that a TODO for next round of changes.

[hausner, 2012-06-08 17:42:35]

Thank you.

http://codereview.chromium.org/10537065/diff/9001/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

http://codereview.chromium.org/10537065/diff/9001/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:637: return class_name.Equals("TypeError") ||
class_name.Equals("AssertionError");
That is my end goal. I think it would be nice if users could select from a list
of exceptions, or all handled or unhandled exceptions. That is for a future
checkin. What I have here is good enough for the demo that Lars wants.

On 2012/06/08 17:17:27, asiva wrote:
> There may be a use case to treat these two separately, that is somebody wants
to
> stop only on type errors vs somebody who wants to stop on user introduced
> assertions.

http://codereview.chromium.org/10537065/diff/9001/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

http://codereview.chromium.org/10537065/diff/9001/runtime/vm/exceptions.cc#ne...
runtime/vm/exceptions.cc:247: void Exceptions::Throw(const Instance& exception)
{
On 2012/06/08 17:17:27, asiva wrote:
> Isolate* isolate = Isolate::Current();
> if (isolate-debugger()....) {
> .....
> }

Done.

http://codereview.chromium.org/10537065/diff/9001/runtime/vm/exceptions.cc#ne...
runtime/vm/exceptions.cc:252: ThrowExceptionHelper(exception,
Instance::Handle());
On 2012/06/08 17:17:27, asiva wrote:
> Instance::Handle(isolate);

Done.

http://codereview.chromium.org/10537065/diff/9001/tools/ddbg.dart
File tools/ddbg.dart (right):

http://codereview.chromium.org/10537065/diff/9001/tools/ddbg.dart#newcode99
tools/ddbg.dart:99: sendCmd(cmd).then((result) => handleSetBpResponse(result));
It is a todo. I need to implement the API and wire protocol for this first.
That's the next step.

On 2012/06/08 17:17:27, asiva wrote:
> No command to be able to say
> "stop on type errors"
> "stop on assertion errors" etc.
> or is that a TODO for next round of changes.