Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 10537053: Remove erroneous assert from dart:io's File class. (Closed)

Created:
8 years, 6 months ago by Bill Hesse
Modified:
8 years, 6 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove erroneous assert from dart:io's File class. BUG= TEST=standalone/io/file_test.dart Committed: https://code.google.com/p/dart/source/detail?r=8396

Patch Set 1 #

Patch Set 2 : Add code to handle asserting case. #

Patch Set 3 : move blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M runtime/bin/file_impl.dart View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
8 years, 6 months ago (2012-06-07 14:11:18 UTC) #1
ricow1
LGTM, we should fix this special case in a follow up (not do any work ...
8 years, 6 months ago (2012-06-07 14:17:07 UTC) #2
ricow1
8 years, 6 months ago (2012-06-07 14:22:55 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698