Issue 10537051: Add type testers to all IL Computation classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10537051: Add type testers to all IL Computation classes. (Closed)

Created:
8 years, 6 months ago by Florian Schneider

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Add type testers to all IL classes. This change does not change any functionality. Until now we only had a select number of type-testers. The CL adds Is- test predicates and As- type cast function for all computations. It is in preparation for upcoming changes where I need to test different computations for their type. Committed: https://code.google.com/p/dart/source/detail?r=8390

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -9 lines)			Patch
	M	vm/intermediate_language.h	View		5 chunks	+27 lines, -9 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://chromiumcodereview.appspot.com/10537051/diff/1/vm/intermediate_language.h File vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/10537051/diff/1/vm/intermediate_language.h#newcode158 vm/intermediate_language.h:158: return reinterpret_cast<ClassName*>(this); \ this should be static_cast.

8 years, 6 months ago (2012-06-07 12:07:16 UTC) #2

Florian Schneider

8 years, 6 months ago (2012-06-07 12:31:47 UTC) #3

https://chromiumcodereview.appspot.com/10537051/diff/1/vm/intermediate_langua...
File vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10537051/diff/1/vm/intermediate_langua...
vm/intermediate_language.h:158: return reinterpret_cast<ClassName*>(this);      
                       \
On 2012/06/07 12:07:16, Vyacheslav Egorov (Google) wrote:
> this should be static_cast.

Done.

Expand Messages | Collapse Messages