Issue 10536143: Detect continue inside of case statement with no label

Issue 10536143: Detect continue inside of case statement with no label (Closed)

Created:
8 years, 6 months ago by zundel

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Detect continue inside of case statement with no label Committed: https://code.google.com/p/dart/source/detail?r=8627

Patch Set 2 : Fixed problem with function definitions inside case stmts #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -28 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1	12 chunks	+36 lines, -26 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

Other than the one comment, LGTM. https://chromiumcodereview.appspot.com/10536143/diff/1007/compiler/java/com/google/dart/compiler/parser/DartParser.java File compiler/java/com/google/dart/compiler/parser/DartParser.java (right): https://chromiumcodereview.appspot.com/10536143/diff/1007/compiler/java/com/google/dart/compiler/parser/DartParser.java#newcode3148 compiler/java/com/google/dart/compiler/parser/DartParser.java:3148: inLoopStatement = false; ...

8 years, 6 months ago (2012-06-13 14:57:58 UTC) #2

zundel

PTAL https://chromiumcodereview.appspot.com/10536143/diff/1007/compiler/java/com/google/dart/compiler/parser/DartParser.java File compiler/java/com/google/dart/compiler/parser/DartParser.java (right): https://chromiumcodereview.appspot.com/10536143/diff/1007/compiler/java/com/google/dart/compiler/parser/DartParser.java#newcode3148 compiler/java/com/google/dart/compiler/parser/DartParser.java:3148: inLoopStatement = false; On 2012/06/13 14:57:58, Brian Wilkerson ...

8 years, 6 months ago (2012-06-13 15:28:32 UTC) #3

LGTM

Expand Messages | Collapse Messages