Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 10536118: Create an initial port. (Closed)

Created:
8 years, 6 months ago by floitsch
Modified:
8 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create an initial port. Committed: https://code.google.com/p/dart/source/detail?r=8599

Patch Set 1 #

Patch Set 2 : Rename __port to _lazy_port #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M lib/isolate/frog/isolateimpl.dart View 1 2 chunks +8 lines, -2 lines 0 comments Download
M tests/co19/co19-leg.status View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
If I add an initial ReceivePort we get a lot more tests passing. I currently ...
8 years, 6 months ago (2012-06-12 16:05:40 UTC) #1
kasperl
LGTM!
8 years, 6 months ago (2012-06-12 16:07:55 UTC) #2
floitsch
Renamed __port to _lazy_port.
8 years, 6 months ago (2012-06-13 10:38:38 UTC) #3
kasperl
On 2012/06/13 10:38:38, floitsch wrote: > Renamed __port to _lazy_port. _lazyPort?
8 years, 6 months ago (2012-06-13 10:39:54 UTC) #4
floitsch
8 years, 6 months ago (2012-06-13 10:46:12 UTC) #5
On 2012/06/13 10:39:54, kasperl wrote:
> On 2012/06/13 10:38:38, floitsch wrote:
> > Renamed __port to _lazy_port.
> 
> _lazyPort?

Done in follow-up CL.

Powered by Google App Engine
This is Rietveld 408576698