Issue 10536116: Reapply "Refactor Date implementation in VM."

Issue 10536116: Reapply "Refactor Date implementation in VM." (Closed)

Created:
8 years, 6 months ago by floitsch

Modified:
8 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Refactor Date implementation in VM." This reapplies a fixed version of commit 8533. https://chromiumcodereview.appspot.com//10533068 Committed: https://code.google.com/p/dart/source/detail?r=8542

Patch Set 3 : Address comment. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+411 lines, -569 lines)			Patch
M	corelib/src/date.dart	View		4 chunks	+8 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/lib/js_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/lib/mockimpl.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/lib/date.cc	View		2 chunks	+18 lines, -217 lines	0 comments	Download
M	runtime/lib/date.dart	View		6 chunks	+218 lines, -164 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	runtime/vm/os.h	View		1 chunk	+7 lines, -28 lines	0 comments	Download
M	runtime/vm/os_linux.cc	View		2 chunks	+15 lines, -44 lines	0 comments	Download
M	runtime/vm/os_macos.cc	View	1	2 chunks	+15 lines, -44 lines	0 comments	Download
M	runtime/vm/os_win.cc	View	1	3 chunks	+20 lines, -54 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/corelib/date_time_test.dart	View		5 chunks	+100 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

Patch-set 0 is the original CL. Patch-set 1 contains the fixes.

8 years, 6 months ago (2012-06-12 11:27:31 UTC) #1

kasperl

LGTM. https://chromiumcodereview.appspot.com/10536116/diff/2001/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://chromiumcodereview.appspot.com/10536116/diff/2001/tests/co19/co19-runtime.status#newcode138 tests/co19/co19-runtime.status:138: LibTest/core/Date/year_A01_t01: Fail, Pass File bug somewhere for this ...

8 years, 6 months ago (2012-06-12 11:56:58 UTC) #2

floitsch

8 years, 6 months ago (2012-06-12 12:04:04 UTC) #3

https://chromiumcodereview.appspot.com/10536116/diff/2001/tests/co19/co19-run...
File tests/co19/co19-runtime.status (right):

https://chromiumcodereview.appspot.com/10536116/diff/2001/tests/co19/co19-run...
tests/co19/co19-runtime.status:138: LibTest/core/Date/year_A01_t01: Fail, Pass
On 2012/06/12 11:56:58, kasperl wrote:
> File bug somewhere for this flaky one?

They are not flaky but use the deprecated Date interface.
Issue co19 - 125
Added comment.

Expand Messages | Collapse Messages