Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10536114: Revert "Refactor Date implementation in VM." (Closed)

Created:
8 years, 6 months ago by floitsch
Modified:
8 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Refactor Date implementation in VM." This reverts commit 8533. Committed: https://code.google.com/p/dart/source/detail?r=8535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+568 lines, -410 lines) Patch
M corelib/src/date.dart View 4 chunks +4 lines, -8 lines 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/mockimpl.dart View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/lib/date.cc View 2 chunks +217 lines, -18 lines 0 comments Download
M runtime/lib/date.dart View 6 chunks +164 lines, -218 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +7 lines, -1 line 0 comments Download
M runtime/vm/os.h View 1 chunk +28 lines, -7 lines 0 comments Download
M runtime/vm/os_linux.cc View 2 chunks +44 lines, -15 lines 0 comments Download
M runtime/vm/os_macos.cc View 2 chunks +44 lines, -15 lines 0 comments Download
M runtime/vm/os_win.cc View 3 chunks +54 lines, -22 lines 0 comments Download
M tests/corelib/date_time_test.dart View 5 chunks +4 lines, -100 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
floitsch
TBR.
8 years, 6 months ago (2012-06-12 10:33:19 UTC) #1
kasperl
8 years, 6 months ago (2012-06-12 10:34:23 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698