Issue 10536089: Stop skipping for Safari and Firefox and allow even more stuff pass on IE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10536089: Stop skipping for Safari and Firefox and allow even more stuff pass on IE. (Closed)

Created:
8 years, 6 months ago by kasperl

Modified:
8 years, 6 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Stop skipping for Safari and Firefox and allow even more stuff pass on IE. TBR'ed. R=ngeoffray@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8481

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
	M	tests/corelib/corelib.status	View		1 chunk	+6 lines, -6 lines	0 comments	Download
	M	tests/language/language_dart2js.status	View		5 chunks	+7 lines, -7 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years, 6 months ago (2012-06-11 08:28:25 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10536089/diff/1/tests/language/languag...
File tests/language/language_dart2js.status (left):

https://chromiumcodereview.appspot.com/10536089/diff/1/tests/language/languag...
tests/language/language_dart2js.status:240: label_test: Skip # Timeout
Note that the timeout here AFAIR is due to invalid generated JS. I think
selenium just doesn't report any error on invalid JS.

Expand Messages | Collapse Messages