Cleans up warnings in dartc code base

Cleans up warnings in dartc code base

Committed: https://code.google.com/p/dart/source/detail?r=8402

[zundel, 2012-06-07 13:06:49]

Just a mechanical cleanup based on warning markers in eclipse.

https://chromiumcodereview.appspot.com/10536052/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
(left):

https://chromiumcodereview.appspot.com/10536052/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:2068:

I wasn't sure about removing this. There are no references, but maybe it was
kept around for some reason?

[Brian Wilkerson, 2012-06-07 13:54:11]

Except for the changes in TopLevelElementBuilder, LGTM. Konstantin can answer
your question about the method, but I believe he recently replaced it by a more
general method and therefore it is no longer needed.

https://chromiumcodereview.appspot.com/10536052/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java
(left):

https://chromiumcodereview.appspot.com/10536052/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java:63:
Scope importScope = library.getElement().getImportScope();
Both of the lines in this file are part of future work to separate the name
space for imported names from the name space for names declared in a library
directly. Please leave them.

[scheglov, 2012-06-07 14:53:58]

LGTM

>
https://chromiumcodereview.appspot.com/10536052/diff/1/compiler/javatests/com...
>
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:2068:
> 
> I wasn't sure about removing this. There are no references, but maybe it was
> kept around for some reason?

I was going to use it, but never did this.
So, yes, it should be removed.