Issue 10536038: Skip lock file pub tests on all but the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10536038: Skip lock file pub tests on all but the VM. (Closed)

Created:
8 years, 6 months ago by Bob Nystrom

Modified:
8 years, 6 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Skip lock file pub tests on all but the VM. Committed: https://code.google.com/p/dart/source/detail?r=8364

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	utils/tests/pub/pub.status	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

8 years, 6 months ago (2012-06-06 21:33:52 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10536038/diff/1/utils/tests/pub/pub.st...
File utils/tests/pub/pub.status (right):

https://chromiumcodereview.appspot.com/10536038/diff/1/utils/tests/pub/pub.st...
utils/tests/pub/pub.status:10: lock_file_test: Skip
could these all be *: Skip? That seems less error prone.
I guess you want to run yaml_test, and that's the issue? 

It seems okay IMO to only have yaml tests running on the VM, if it simplifies
maintenance of the status file

Expand Messages | Collapse Messages