Issue 10536006: Fix NodeSelector interface.

Issue 10536006: Fix NodeSelector interface. (Closed)

Created:
8 years, 6 months ago by podivilov

Modified:
8 years, 6 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix NodeSelector interface. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=8281

Patch Set 2 : Remove NodeSelector from dart.idl. #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -85 lines)			Patch
M	lib/dom/dom.dart	View	1	4 chunks	+3 lines, -15 lines	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View	1	4 chunks	+3 lines, -15 lines	0 comments	Download
M	lib/dom/idl/dart/dart.idl	View	1	1 chunk	+0 lines, -9 lines	1 comment	Download
M	lib/dom/templates/html/interface/interface_Element.darttemplate	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		2 chunks	+5 lines, -22 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View		2 chunks	+5 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm w/ comments btw, why this rename needed? https://chromiumcodereview.appspot.com/10536006/diff/1/lib/dom/idl/dart/dart.idl File lib/dom/idl/dart/dart.idl (right): https://chromiumcodereview.appspot.com/10536006/diff/1/lib/dom/idl/dart/dart.idl#newcode37 lib/dom/idl/dart/dart.idl:37: // ...

8 years, 6 months ago (2012-06-05 11:41:59 UTC) #2

podivilov

These are shorter names used in dart:html. PTAL. http://codereview.chromium.org/10536006/diff/1/lib/dom/idl/dart/dart.idl File lib/dom/idl/dart/dart.idl (right): http://codereview.chromium.org/10536006/diff/1/lib/dom/idl/dart/dart.idl#newcode37 lib/dom/idl/dart/dart.idl:37: // ...

8 years, 6 months ago (2012-06-05 11:57:21 UTC) #3

Anton Muhin

8 years, 6 months ago (2012-06-05 13:45:27 UTC) #4

lgtm

http://codereview.chromium.org/10536006/diff/3001/lib/dom/idl/dart/dart.idl
File lib/dom/idl/dart/dart.idl (left):

http://codereview.chromium.org/10536006/diff/3001/lib/dom/idl/dart/dart.idl#o...
lib/dom/idl/dart/dart.idl:239: }
bad podivilov :)

Expand Messages | Collapse Messages