Issue 10535178: Document the ByteArray types and reconcile with the implementation.

Issue 10535178: Document the ByteArray types and reconcile with the implementation. (Closed)

Created:
8 years, 6 months ago by cshapiro

Modified:
8 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Document the ByteArray types and reconcile with the implementation. BUG=1499 Committed: https://code.google.com/p/dart/source/detail?r=8738

Patch Set 2 : address review comments #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+593 lines, -36 lines)			Patch
	M	runtime/lib/byte_array.cc	View		2 chunks	+9 lines, -3 lines	0 comments	Download
	M	runtime/lib/byte_array.dart	View	1	2 chunks	+584 lines, -33 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm http://codereview.chromium.org/10535178/diff/1/runtime/lib/byte_array.dart File runtime/lib/byte_array.dart (right): http://codereview.chromium.org/10535178/diff/1/runtime/lib/byte_array.dart#newcode57 runtime/lib/byte_array.dart:57: * -128 and 127, inclusive. must be between ...

8 years, 6 months ago (2012-06-15 01:52:46 UTC) #2

cshapiro

8 years, 6 months ago (2012-06-15 20:13:19 UTC) #3

http://codereview.chromium.org/10535178/diff/1/runtime/lib/byte_array.dart
File runtime/lib/byte_array.dart (right):

http://codereview.chromium.org/10535178/diff/1/runtime/lib/byte_array.dart#ne...
runtime/lib/byte_array.dart:57: * -128 and 127, inclusive.
You are suggesting that "lie" be substituted for "be", right?  If so, it has
been fixed.

http://codereview.chromium.org/10535178/diff/1/runtime/lib/byte_array.dart#ne...
runtime/lib/byte_array.dart:57: * -128 and 127, inclusive.
I assume you mean to substitute "be" for "lie", right?  If so, it is now fixed.

http://codereview.chromium.org/10535178/diff/1/runtime/lib/byte_array.dart#ne...
runtime/lib/byte_array.dart:124: * or greater than 2<sup>15 - 1,
I assume you mean ',' instead of '.', right?  If so, it is now fixed.

http://codereview.chromium.org/10535178/diff/1/runtime/lib/byte_array.dart#ne...
runtime/lib/byte_array.dart:181: * or greater than 2<sup>31 - 1,
On 2012/06/15 01:52:47, asiva wrote:
> Ditto.

Done.

http://codereview.chromium.org/10535178/diff/1/runtime/lib/byte_array.dart#ne...
runtime/lib/byte_array.dart:236: * or greater than 2<sup>63 - 1,
On 2012/06/15 01:52:47, asiva wrote:
> Ditto

Done.

Expand Messages | Collapse Messages