Changes to the i18n messages so that they are invoked as

Changes to the i18n messages so that they are invoked as
 intl.message(...)
and the result is a function whose evaluation gives you the result string.
Committed: https://code.google.com/p/dart/source/detail?r=8471

[Emily Fortuna, 2012-06-08 21:50:37]

lgtm, with comments! :-)

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl.dart
File lib/i18n/intl.dart (right):

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl.dart#...
lib/i18n/intl.dart:40: * [message_str] which is string to be translated, which
may be interpolated
"which is string to be" => "that will be"
(we don't need to specify type because it's already in the method signature, and
the sentence as written doesn't quite make sense)

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl_messa...
File lib/i18n/intl_message.dart (right):

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl_messa...
lib/i18n/intl_message.dart:19: *          examples: {'date' : 'June 8, 2012'});
I'd recommend not using a date in this example because date formatting is a
whole different animal....

https://chromiumcodereview.appspot.com/10535087/diff/8001/tests/lib/i18n/intl...
File tests/lib/i18n/intl_message_test.dart (right):

https://chromiumcodereview.appspot.com/10535087/diff/8001/tests/lib/i18n/intl...
tests/lib/i18n/intl_message_test.dart:16: 
get rid of extra whitespace, please

https://chromiumcodereview.appspot.com/10535087/diff/8001/tests/lib/i18n/intl...
tests/lib/i18n/intl_message_test.dart:23: 
extra whitespace

[Alan Knight, 2012-06-08 22:04:53]

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl.dart
File lib/i18n/intl.dart (right):

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl.dart#...
lib/i18n/intl.dart:40: * [message_str] which is string to be translated, which
may be interpolated
On 2012/06/08 21:50:37, Emily Fortuna wrote:
> "which is string to be" => "that will be"
> (we don't need to specify type because it's already in the method signature,
and
> the sentence as written doesn't quite make sense)

Yes, too many rewrites in a row... Done.

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl_messa...
File lib/i18n/intl_message.dart (right):

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl_messa...
lib/i18n/intl_message.dart:19: *          examples: {'date' : 'June 8, 2012'});
On 2012/06/08 21:50:37, Emily Fortuna wrote:
> I'd recommend not using a date in this example because date formatting is a
> whole different animal....

I thought it was actually good to start having examples with them. It'll just
use the default format, but that's true for numbers, too.

https://chromiumcodereview.appspot.com/10535087/diff/8001/tests/lib/i18n/intl...
File tests/lib/i18n/intl_message_test.dart (right):

https://chromiumcodereview.appspot.com/10535087/diff/8001/tests/lib/i18n/intl...
tests/lib/i18n/intl_message_test.dart:16: 
On 2012/06/08 21:50:37, Emily Fortuna wrote:
> get rid of extra whitespace, please

Done.

https://chromiumcodereview.appspot.com/10535087/diff/8001/tests/lib/i18n/intl...
tests/lib/i18n/intl_message_test.dart:23: 
On 2012/06/08 21:50:37, Emily Fortuna wrote:
> extra whitespace

I thought this was useful as being something that's declaring a variable used in
all of the tests, so associating it with the first one seemed misleading.

[Emily Fortuna, 2012-06-08 22:09:40]

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl_messa...
File lib/i18n/intl_message.dart (right):

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl_messa...
lib/i18n/intl_message.dart:19: *          examples: {'date' : 'June 8, 2012'});
On 2012/06/08 22:04:53, Alan Knight wrote:
> On 2012/06/08 21:50:37, Emily Fortuna wrote:
> > I'd recommend not using a date in this example because date formatting is a
> > whole different animal....
> 
> I thought it was actually good to start having examples with them. It'll just
> use the default format, but that's true for numbers, too. 

Yeah, but technically, you should probably say something like "Today's date is
${DateFormat.format("yM", date)}" which just seems more trouble to explain than
it's worth.

https://chromiumcodereview.appspot.com/10535087/diff/8001/tests/lib/i18n/intl...
File tests/lib/i18n/intl_message_test.dart (right):

https://chromiumcodereview.appspot.com/10535087/diff/8001/tests/lib/i18n/intl...
tests/lib/i18n/intl_message_test.dart:23: 
On 2012/06/08 22:04:53, Alan Knight wrote:
> On 2012/06/08 21:50:37, Emily Fortuna wrote:
> > extra whitespace
> 
> I thought this was useful as being something that's declaring a variable used
in
> all of the tests, so associating it with the first one seemed misleading.

The problem is not the whitespace at line 25, but the whitespace at line 23.

[Alan Knight, 2012-06-08 22:14:21]

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl_messa...
File lib/i18n/intl_message.dart (right):

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl_messa...
lib/i18n/intl_message.dart:19: *          examples: {'date' : 'June 8, 2012'});
On 2012/06/08 22:09:40, Emily Fortuna wrote:
> On 2012/06/08 22:04:53, Alan Knight wrote:
> > On 2012/06/08 21:50:37, Emily Fortuna wrote:
> > > I'd recommend not using a date in this example because date formatting is
a
> > > whole different animal....
> > 
> > I thought it was actually good to start having examples with them. It'll
just
> > use the default format, but that's true for numbers, too. 
> 
> Yeah, but technically, you should probably say something like "Today's date is
> ${DateFormat.format("yM", date)}" which just seems more trouble to explain
than
> it's worth.

But on the same basis, below I should probably write ${NumFormat.format('i',
num_people)}, which is similarly too much. I figured it's all right to put in
something that just uses a default, especially for the moment, and explain the
more complicated parts as they come up, or in more fully worked out examples.

https://chromiumcodereview.appspot.com/10535087/diff/8001/tests/lib/i18n/intl...
File tests/lib/i18n/intl_message_test.dart (right):

https://chromiumcodereview.appspot.com/10535087/diff/8001/tests/lib/i18n/intl...
tests/lib/i18n/intl_message_test.dart:23: 
On 2012/06/08 22:09:40, Emily Fortuna wrote:
> On 2012/06/08 22:04:53, Alan Knight wrote:
> > On 2012/06/08 21:50:37, Emily Fortuna wrote:
> > > extra whitespace
> > 
> > I thought this was useful as being something that's declaring a variable
used
> in
> > all of the tests, so associating it with the first one seemed misleading.
> 
> The problem is not the whitespace at line 25, but the whitespace at line 23.

Ah, ok. Done.

[Emily Fortuna, 2012-06-08 22:17:14]

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl_messa...
File lib/i18n/intl_message.dart (right):

https://chromiumcodereview.appspot.com/10535087/diff/8001/lib/i18n/intl_messa...
lib/i18n/intl_message.dart:19: *          examples: {'date' : 'June 8, 2012'});
On 2012/06/08 22:14:21, Alan Knight wrote:
> On 2012/06/08 22:09:40, Emily Fortuna wrote:
> > On 2012/06/08 22:04:53, Alan Knight wrote:
> > > On 2012/06/08 21:50:37, Emily Fortuna wrote:
> > > > I'd recommend not using a date in this example because date formatting
is
> a
> > > > whole different animal....
> > > 
> > > I thought it was actually good to start having examples with them. It'll
> just
> > > use the default format, but that's true for numbers, too. 
> > 
> > Yeah, but technically, you should probably say something like "Today's date
is
> > ${DateFormat.format("yM", date)}" which just seems more trouble to explain
> than
> > it's worth.
> 
> But on the same basis, below I should probably write ${NumFormat.format('i',
> num_people)}, which is similarly too much. I figured it's all right to put in
> something that just uses a default, especially for the moment, and explain the
> more complicated parts as they come up, or in more fully worked out examples.

Fine. The difference being we have an API already written for DateFormat, but
not for NumberFormat...