Issue 10535074: Add field getters and setters to the collection of getters and setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10535074: Add field getters and setters to the collection of getters and setters. (Closed)

Created:
8 years, 6 months ago by Søren Gjesse

Modified:
8 years, 6 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Collect field getters and setters in the universe This is intended to replace the setter information collection used in http://codereview.chromium.org/10537025/. R=ngeoffray@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8487

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -12 lines)			Patch
M	lib/compiler/implementation/emitter.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/enqueue.dart	View	1 2	5 chunks	+23 lines, -7 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/universe.dart	View	1	3 chunks	+14 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Gjesse

PTAL Addressed comments discussed off-line. The field getters/setters are now stored in a separate collection. ...

8 years, 6 months ago (2012-06-11 13:30:35 UTC) #2

LGTM!