Issue 10535066: 1. Remove recursion during snapshot writing and reading

Issue 10535066: 1. Remove recursion during snapshot writing and reading (Closed)

Created:
8 years, 6 months ago by siva

Modified:
8 years, 6 months ago

Reviewers:
Søren Gjesse, cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

1. Remove recursion during snapshot writing and reading 2. set thread stack size to 128k 3. Fix the native message handler to ensure that it works with the new model of not recursively inlining objects. Committed: https://code.google.com/p/dart/source/detail?r=8517

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 12

Patch Set 6 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+813 lines, -287 lines)			Patch
M	platform/thread_linux.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	platform/thread_macos.cc	View	1 2 3 4 5	1 chunk	+0 lines, -4 lines	0 comments	Download
M	vm/dart_api_message.h	View	1 2 3 4 5	6 chunks	+38 lines, -5 lines	0 comments	Download
M	vm/dart_api_message.cc	View	1 2 3 4 5	14 chunks	+215 lines, -58 lines	0 comments	Download
M	vm/raw_object_snapshot.cc	View	1 2 3 4 5	50 chunks	+85 lines, -131 lines	0 comments	Download
M	vm/snapshot.h	View	1 2 3 4 5	10 chunks	+95 lines, -13 lines	0 comments	Download
M	vm/snapshot.cc	View	1 2 3 4 5	16 chunks	+379 lines, -75 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/10535066/diff/2005/vm/dart_api_message.cc File vm/dart_api_message.cc (right): https://chromiumcodereview.appspot.com/10535066/diff/2005/vm/dart_api_message.cc#newcode723 vm/dart_api_message.cc:723: // not been serialized yet. These would typically ...

8 years, 6 months ago (2012-06-08 08:12:12 UTC) #3

cshapiro

lgtm http://codereview.chromium.org/10535066/diff/2005/vm/dart_api_message.h File vm/dart_api_message.h (right): http://codereview.chromium.org/10535066/diff/2005/vm/dart_api_message.h#newcode78 vm/dart_api_message.h:78: BackwardReferenceNode* AllocateBackwardReferenceNode(Dart_CObject* reference, Just a suggestion: we already ...

8 years, 6 months ago (2012-06-08 22:04:39 UTC) #4

siva

8 years, 6 months ago (2012-06-11 20:49:06 UTC) #5

http://codereview.chromium.org/10535066/diff/2005/vm/dart_api_message.cc
File vm/dart_api_message.cc (right):

http://codereview.chromium.org/10535066/diff/2005/vm/dart_api_message.cc#newc...
vm/dart_api_message.cc:723: // not been serialized yet. These would typically be
fields of arrays.
On 2012/06/08 08:12:12, Søren Gjesse wrote:
> Maybe extend comment here to mention that the forward list can grow as it is
> processed (same in snapshot writer).

Done.

http://codereview.chromium.org/10535066/diff/2005/vm/dart_api_message.h
File vm/dart_api_message.h (right):

http://codereview.chromium.org/10535066/diff/2005/vm/dart_api_message.h#newco...
vm/dart_api_message.h:78: BackwardReferenceNode*
AllocateBackwardReferenceNode(Dart_CObject* reference,
On 2012/06/08 22:04:39, cshapiro wrote:
> Just a suggestion: we already shorten "Reference" to "Ref" in this context. 
> Seeing as how the indentation is getting crazy here and elsewhere to
accommodate
> the long name, you couldwant shorten "BackwardReference" to "BackwardRef" or
> even "BackRef" to keep things more naturally within the margin.

Done.

http://codereview.chromium.org/10535066/diff/2005/vm/snapshot.h
File vm/snapshot.h (right):

http://codereview.chromium.org/10535066/diff/2005/vm/snapshot.h#newcode361
vm/snapshot.h:361: void AddBackwardReference(intptr_t id, Object* obj, bool
is_deserialized);
On 2012/06/08 22:04:39, cshapiro wrote:
> Can we make this an enum instead of a bool?

Done.

http://codereview.chromium.org/10535066/diff/2005/vm/snapshot.h#newcode398
vm/snapshot.h:398: BackwardReferenceNode(Object* reference, bool
is_deserialized)
On 2012/06/08 22:04:39, cshapiro wrote:
> same here

Done.

http://codereview.chromium.org/10535066/diff/2005/vm/snapshot.h#newcode560
vm/snapshot.h:560: ForwardObjectNode(RawObject* raw, uword tags, bool
is_serialized)
On 2012/06/08 22:04:39, cshapiro wrote:
> same here

Done.

http://codereview.chromium.org/10535066/diff/2005/vm/snapshot.h#newcode575
vm/snapshot.h:575: intptr_t MarkObject(RawObject* raw, bool is_serialized);
On 2012/06/08 22:04:39, cshapiro wrote:
> same here

Done.

Expand Messages | Collapse Messages