Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 10535054: fix unparsing "for in" statements (Closed)

Created:
8 years, 6 months ago by Roman
Modified:
8 years, 6 months ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix unparsing "for in" constructs. Source: main() { for (var a in b) { } } Bad unparse result: main(){for (var ainb) {}} BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M lib/compiler/implementation/tree/unparser.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roman
8 years, 6 months ago (2012-06-07 15:09:41 UTC) #1
Anton Muhin
lgtm
8 years, 6 months ago (2012-06-07 15:11:22 UTC) #2
Roman
8 years, 6 months ago (2012-06-07 15:16:20 UTC) #3
Thanks for quick review!

Powered by Google App Engine
This is Rietveld 408576698