Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 10534158: Fix flaky test runtime/vm/heap_profiler_test.cc (Closed)

Created:
8 years, 6 months ago by Bill Hesse
Modified:
8 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix flaky test runtime/vm/heap_profiler_test.cc BUG=3634 TEST=vm/heap_profiler_test Committed: https://code.google.com/p/dart/source/detail?r=8648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/heap_profiler_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
The >= and <= checks were reversed. The test was flaky because the values are ...
8 years, 6 months ago (2012-06-14 11:35:22 UTC) #1
Mads Ager (google)
lgtm
8 years, 6 months ago (2012-06-14 11:43:02 UTC) #2
cshapiro
8 years, 6 months ago (2012-06-14 19:21:07 UTC) #3
lgtm, too

thanks

Powered by Google App Engine
This is Rietveld 408576698