Issue 10534135: Add test case for issue 3147.

Issue 10534135: Add test case for issue 3147. (Closed)

Created:
8 years, 6 months ago by ngeoffray

Modified:
8 years, 6 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), kasperl

CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add test case for issue 3147. Committed: https://code.google.com/p/dart/source/detail?r=8609

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
A	tests/standalone/package/package1_test.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	tests/standalone/package/packages/package1.dart	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
A	tests/standalone/package/packages/package2.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10534135/diff/2001/tests/standalone/package/packages/package1.dart File tests/standalone/package/packages/package1.dart (right): https://chromiumcodereview.appspot.com/10534135/diff/2001/tests/standalone/package/packages/package1.dart#newcode7 tests/standalone/package/packages/package1.dart:7: #import('package2.dart', prefix: 'b1'); bn -> pn?

8 years, 6 months ago (2012-06-13 12:40:09 UTC) #2

ngeoffray

Thanks Kasper https://chromiumcodereview.appspot.com/10534135/diff/2001/tests/standalone/package/packages/package1.dart File tests/standalone/package/packages/package1.dart (right): https://chromiumcodereview.appspot.com/10534135/diff/2001/tests/standalone/package/packages/package1.dart#newcode7 tests/standalone/package/packages/package1.dart:7: #import('package2.dart', prefix: 'b1'); On 2012/06/13 12:40:10, kasperl ...

8 years, 6 months ago (2012-06-13 12:55:20 UTC) #3

LGTM
Thank you!

Expand Messages | Collapse Messages