Issue 10534130: Wrap Location object on Firefox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10534130: Wrap Location object on Firefox. (Closed)

Created:
8 years, 6 months ago by sra1

Modified:
8 years, 6 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Wrap Location object on Firefox. This is a fix for Issue 3152. https://code.google.com/p/dart/issues/detail?id=3152 Committed: https://code.google.com/p/dart/source/detail?r=8635

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+273 lines, -2 lines)			Patch
M	lib/dom/scripts/systemhtml.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/dom/templates/html/frog/html_frog.darttemplate	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/dom/templates/html/frog/impl_Window.darttemplate	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View		3 chunks	+126 lines, -2 lines	0 comments	Download
A	lib/html/src/frog_LocationWrapper.dart	View	1	1 chunk	+73 lines, -0 lines	0 comments	Download
A	tests/html/location_test.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 6 months ago (2012-06-13 04:34:02 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10534130/diff/6007/lib/dom/templates/h...
File lib/dom/templates/html/frog/impl_Window.darttemplate (right):

https://chromiumcodereview.appspot.com/10534130/diff/6007/lib/dom/templates/h...
lib/dom/templates/html/frog/impl_Window.darttemplate:19: void set
location(Location value) => _set_location(value);
This was probably broken before, but the setter should allow a string here and
below.

https://chromiumcodereview.appspot.com/10534130/diff/6007/lib/dom/templates/h...
lib/dom/templates/html/frog/impl_Window.darttemplate:48: _protect_location()
native 'location';
Is this used?

https://chromiumcodereview.appspot.com/10534130/diff/6007/lib/html/src/frog_L...
File lib/html/src/frog_LocationWrapper.dart (right):

https://chromiumcodereview.appspot.com/10534130/diff/6007/lib/html/src/frog_L...
lib/html/src/frog_LocationWrapper.dart:16: // TODO(sra): Replace all the _set
and _get calls 'JS' forms.
calls *with* 'JS'

Expand Messages | Collapse Messages