Issue 10534114: Reapply "Refactor Date implementation in VM."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10534114: Reapply "Refactor Date implementation in VM." (Closed)

Created:
8 years, 6 months ago by floitsch

Modified:
8 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Reapply "Refactor Date implementation in VM." This reapplies fixed versions of commit 7542 and commit 8544. Original review URLs: https://chromiumcodereview.appspot.com//10533068 https://chromiumcodereview.appspot.com//10544109 Committed: https://code.google.com/p/dart/source/detail?r=8655

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+417 lines, -575 lines)			Patch
M	corelib/src/date.dart	View		4 chunks	+8 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/lib/js_helper.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/lib/mockimpl.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/lib/date.cc	View		2 chunks	+18 lines, -217 lines	0 comments	Download
M	runtime/lib/date.dart	View	1 2 3 4 5	6 chunks	+218 lines, -164 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 2	1 chunk	+1 line, -7 lines	0 comments	Download
M	runtime/vm/os.h	View		1 chunk	+7 lines, -28 lines	0 comments	Download
M	runtime/vm/os_linux.cc	View		2 chunks	+15 lines, -44 lines	0 comments	Download
M	runtime/vm/os_macos.cc	View		2 chunks	+15 lines, -44 lines	0 comments	Download
M	runtime/vm/os_win.cc	View		3 chunks	+20 lines, -54 lines	0 comments	Download
M	samples/total/client/DateTimeUtils.dart	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/corelib/date_time_test.dart	View		5 chunks	+100 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

floitsch

Diff to patchset 4 to see the fix. (The other uploads are just rebases).

8 years, 6 months ago (2012-06-14 12:59:21 UTC) #1

LGTM.