Issue 10534111: Revert "Refactor Date implementation in VM."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10534111: Revert "Refactor Date implementation in VM." (Closed)

Created:
8 years, 6 months ago by floitsch

Modified:
8 years, 6 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Refactor Date implementation in VM." Also revert "Round days-computation to get rid of daylight-savings differences." This reverts commit 7542 and commit 8544. Committed: https://code.google.com/p/dart/source/detail?r=8547

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+575 lines, -417 lines)			Patch
M	corelib/src/date.dart	View	4 chunks	+4 lines, -8 lines	0 comments	Download
M	lib/compiler/implementation/lib/js_helper.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/lib/mockimpl.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	runtime/lib/date.cc	View	2 chunks	+217 lines, -18 lines	0 comments	Download
M	runtime/lib/date.dart	View	6 chunks	+164 lines, -218 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	runtime/vm/os.h	View	1 chunk	+28 lines, -7 lines	0 comments	Download
M	runtime/vm/os_linux.cc	View	2 chunks	+44 lines, -15 lines	0 comments	Download
M	runtime/vm/os_macos.cc	View	2 chunks	+44 lines, -15 lines	0 comments	Download
M	runtime/vm/os_win.cc	View	3 chunks	+54 lines, -20 lines	0 comments	Download
M	samples/total/client/DateTimeUtils.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-runtime.status	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/corelib/date_time_test.dart	View	5 chunks	+4 lines, -100 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages