Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 10534081: pub: treat a pubspec with just comments as empty (Closed)

Created:
8 years, 6 months ago by kevmoo-old
Modified:
8 years, 5 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pub: treat a pubspec with just comments as empty BUG= http://dartbug.com/3483 TEST= Committed: https://code.google.com/p/dart/source/detail?r=9686

Patch Set 1 #

Total comments: 1

Patch Set 2 : with tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M dart/utils/pub/pubspec.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M dart/utils/tests/pub/pubspec_test.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kevmoo-old
Tiny tweak, but nice if folks have comment-only pubspecs. For instance, they are using library ...
8 years, 6 months ago (2012-06-09 21:42:01 UTC) #1
kevmoo-old
Not sure if I already did this...
8 years, 6 months ago (2012-06-12 03:41:12 UTC) #2
kevmoo-old
Bob told me to bother you w/ this.
8 years, 5 months ago (2012-07-14 21:47:16 UTC) #3
nweiz
Could you also add a test for this to pubspec_test? http://codereview.chromium.org/10534081/diff/1/utils/pub/pubspec.dart File utils/pub/pubspec.dart (right): http://codereview.chromium.org/10534081/diff/1/utils/pub/pubspec.dart#newcode45 ...
8 years, 5 months ago (2012-07-16 19:34:02 UTC) #4
nweiz
8 years, 5 months ago (2012-07-16 22:41:04 UTC) #5
LGTM, I'll go ahead and commit this.

Powered by Google App Engine
This is Rietveld 408576698