Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 10533151: Make undefined and null equivalent. (Closed)

Created:
8 years, 6 months ago by floitsch
Modified:
8 years, 6 months ago
Reviewers:
sra1, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make undefined and null equivalent. Fixes issue 3328. Committed: https://code.google.com/p/dart/source/detail?r=9053

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -67 lines) Patch
M lib/compiler/implementation/compile_time_constants.dart View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M lib/compiler/implementation/emitter.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/interceptors.dart View 1 2 3 2 chunks +8 lines, -5 lines 2 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 2 3 3 chunks +7 lines, -9 lines 0 comments Download
M lib/compiler/implementation/lib/native_helper.dart View 1 2 3 1 chunk +2 lines, -9 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 1 2 3 10 chunks +116 lines, -36 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen_helpers.dart View 1 2 3 4 chunks +14 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/constant_folding_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/field_codegen_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
This is just a preliminary CL, but the results so far are mixed. Some benchmarks ...
8 years, 6 months ago (2012-06-15 15:19:11 UTC) #1
floitsch
I can now reproduce the huge speedups in dromaeo (more than *3 on some tests). ...
8 years, 6 months ago (2012-06-21 09:38:13 UTC) #2
sra1
lgtm. https://chromiumcodereview.appspot.com/10533151/diff/7001/lib/compiler/implementation/lib/interceptors.dart File lib/compiler/implementation/lib/interceptors.dart (right): https://chromiumcodereview.appspot.com/10533151/diff/7001/lib/compiler/implementation/lib/interceptors.dart#newcode453 lib/compiler/implementation/lib/interceptors.dart:453: if (fractionDigits !== null) { !=
8 years, 6 months ago (2012-06-21 19:42:50 UTC) #3
sra1
8 years, 6 months ago (2012-06-21 22:33:23 UTC) #4
still lgtm

https://chromiumcodereview.appspot.com/10533151/diff/7001/lib/compiler/implem...
File lib/compiler/implementation/lib/interceptors.dart (right):

https://chromiumcodereview.appspot.com/10533151/diff/7001/lib/compiler/implem...
lib/compiler/implementation/lib/interceptors.dart:453: if (fractionDigits !==
null) {
On 2012/06/21 19:42:50, sra1 wrote:
> !=

Sorry, this is Dart code :-)
When the new changes to == are implemented and === is removed we will need to do
this.

Powered by Google App Engine
This is Rietveld 408576698