Issue 10533127: Fix for issue 3526

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10533127: Fix for issue 3526 (Closed)

Created:
8 years, 6 months ago by Brian Wilkerson

Modified:
8 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issue 3526 Committed: https://code.google.com/p/dart/source/detail?r=8615

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -7 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View		1 chunk	+14 lines, -6 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

lgtm http://codereview.chromium.org/10533127/diff/1/compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java File compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java (right): http://codereview.chromium.org/10533127/diff/1/compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java#newcode442 compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java:442: DartUnit unit = parseUnit("phony_cast.dart", Joiner.on("\n").join( Why "cast"? http://codereview.chromium.org/10533127/diff/1/compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java#newcode446 ...

8 years, 6 months ago (2012-06-13 15:46:41 UTC) #2

Brian Wilkerson

8 years, 6 months ago (2012-06-13 15:53:37 UTC) #3

http://codereview.chromium.org/10533127/diff/1/compiler/javatests/com/google/...
File compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java (right):

http://codereview.chromium.org/10533127/diff/1/compiler/javatests/com/google/...
compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java:442: DartUnit
unit = parseUnit("phony_cast.dart", Joiner.on("\n").join(
Copy/paste. I've changed it to "super".

http://codereview.chromium.org/10533127/diff/1/compiler/javatests/com/google/...
compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java:446: "   
!super;",
Removed.

Expand Messages | Collapse Messages

Issue 10533127: Fix for issue 3526 (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages