Issue 10533126: Remove string constants from Types class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10533126: Remove string constants from Types class. (Closed)

Created:
8 years, 6 months ago by ahe

Modified:
8 years, 6 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove string constants from Types class. Committed: https://code.google.com/p/dart/source/detail?r=8660

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -28 lines)			Patch
M	dart/lib/compiler/implementation/elements/elements.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/lib/compiler/implementation/resolver.dart	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	dart/lib/compiler/implementation/typechecker.dart	View	3 chunks	+3 lines, -20 lines	0 comments	Download
A	dart/tests/language/prefix_core_test.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

ahe

This fixes http://code.google.com/p/dart/issues/detail?id=3604

8 years, 6 months ago (2012-06-13 15:37:23 UTC) #1

LGTM!