Issue 10533110: Make sure that _FileInputStream._fillBuffer is not entered again before it finishes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10533110: Make sure that _FileInputStream._fillBuffer is not entered again before it finishes. (Closed)

Created:
8 years, 6 months ago by Bill Hesse

Modified:
8 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, Anders Johnsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make sure that _FileInputStream._fillBuffer is not entered again before it finishes. Also fix a bug where _fillBuffer did not reset _position correctly. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8553

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	runtime/bin/file_impl.dart	View	1	7 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

http://codereview.chromium.org/10533110/diff/1/runtime/bin/file_impl.dart File runtime/bin/file_impl.dart (right): http://codereview.chromium.org/10533110/diff/1/runtime/bin/file_impl.dart#newcode72 runtime/bin/file_impl.dart:72: _position = _data.length; This was probably the cause of ...

8 years, 6 months ago (2012-06-12 15:18:10 UTC) #1

Ivan Posva

8 years, 6 months ago (2012-06-12 15:56:52 UTC) #2

LGTM with comments.

Please add tests in a future CL.

-Ivan

http://codereview.chromium.org/10533110/diff/1/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/10533110/diff/1/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:68: if (_activeFillBufferCall) return;
Comment about buffer filling in flight please.

http://codereview.chromium.org/10533110/diff/1/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:72: _position = _data.length;
On 2012/06/12 15:18:10, Bill Hesse wrote:
> This was probably the cause of a bug.  It could cause a negative value for
> available().

This is very confusing. Please add a comment explaining what this does.
Basically you are signaling nothing available yet.

http://codereview.chromium.org/10533110/diff/1/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:115: _data = [];
_data = const [];

Expand Messages | Collapse Messages