Issue 10533003: Remove the 'element' field on a HParameterValue to use the 'sourceElement' of HInstruction. Also, w…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10533003: Remove the 'element' field on a HParameterValue to use the 'sourceElement' of HInstruction. Also, w… (Closed)

Created:
8 years, 6 months ago by ngeoffray

Modified:
8 years, 6 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove the 'element' field on a HParameterValue to use the 'sourceElement' of HInstruction. Also, we should keep a type guard when we want a type that is a supertype of the declared type (eg we want num, the declared type is int). Committed: https://code.google.com/p/dart/source/detail?r=8326

Patch Set 1 : #

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	lib/compiler/implementation/ssa/bailout.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	lib/compiler/implementation/ssa/variable_allocator.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages