Issue 10532027: Move interface members traverse logic to BaseGenerator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10532027: Move interface members traverse logic to BaseGenerator. (Closed)

Created:
8 years, 6 months ago by podivilov

Modified:
8 years, 6 months ago

Reviewers:
Anton Muhin, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move interface members traverse logic to BaseGenerator. AddMembers(merged_interface) will be used by systemhtml to add all the members from HTMLElement to Element. R=antonm@google.com,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=8438

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -134 lines)			Patch
M	lib/dom/scripts/dartgenerator.py	View	5 chunks	+7 lines, -103 lines	0 comments	Download
M	lib/dom/scripts/systembase.py	View	3 chunks	+108 lines, -3 lines	2 comments	Download
M	lib/dom/scripts/systemfrog.py	View	4 chunks	+2 lines, -7 lines	0 comments	Download
M	lib/dom/scripts/systeminterface.py	View	4 chunks	+2 lines, -18 lines	0 comments	Download
M	lib/dom/scripts/systemnative.py	View	3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

STV! https://chromiumcodereview.appspot.com/10532027/diff/1/lib/dom/scripts/systembase.py File lib/dom/scripts/systembase.py (right): https://chromiumcodereview.appspot.com/10532027/diff/1/lib/dom/scripts/systembase.py#newcode10 lib/dom/scripts/systembase.py:10: from generator import * may we use qualified ...

8 years, 6 months ago (2012-06-06 14:53:41 UTC) #2

lgtm

Expand Messages | Collapse Messages