Issue 10519011: Properly parse [].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10519011: Properly parse []. (Closed)

Created:
8 years, 6 months ago by Anton Muhin

Modified:
8 years, 6 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Properly parse []. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=8314

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	lib/compiler/implementation/scanner/array_based_scanner.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	lib/compiler/implementation/scanner/scanner.dart	View		2 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 6 months ago (2012-06-06 08:38:26 UTC) #2

LGTM!

I'm not 100% comfortable with the previousToken method. However, it looks like a
small and simple solution, and I don't have a better suggestion.

Cheers,
Peter

Expand Messages | Collapse Messages