Move splitting operations with optional arguments to generator.

Move splitting operations with optional arguments to generator.

To generate v8-like overload resolver we need original list of overloads.
It is much easier to slit operations in generator where needed than to split
them in databasebuilder and then combine again in generator.

R=antonm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=8277

[Anton Muhin, 2012-06-04 14:43:13]

LGTM w/ comments addressed

https://chromiumcodereview.appspot.com/10517004/diff/1/lib/dom/scripts/databa...
File lib/dom/scripts/databasebuilder.py (right):

https://chromiumcodereview.appspot.com/10517004/diff/1/lib/dom/scripts/databa...
lib/dom/scripts/databasebuilder.py:126: for i in range(0, len(op.arguments)):
it looks like for argument in op.arguments is now enough

https://chromiumcodereview.appspot.com/10517004/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10517004/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:214: def NeedsDefaultValue(argument):
maybe it should be named IsOptional?

https://chromiumcodereview.appspot.com/10517004/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:249: if IsOptional(operation.arguments[i]):
controversial:

maybe make it explicit that once we met optional argument, the rest is assumed
to be optional:

for i, argument in enumerate(operation.arguments):
  if IsOptional(argument):
    for j in range(i, len(operation.arguments) - 1):
      new_operation = copy.deepcopy(operation)
      new_operation.arguments = new_operation.arguments[:j]
      split_operations.append(new_operation)

https://chromiumcodereview.appspot.com/10517004/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:250: new_operation = copy.deepcopy(operation)
are you sure you need deepcopy here?

[podivilov, 2012-06-04 15:12:02]

http://codereview.chromium.org/10517004/diff/1/lib/dom/scripts/databasebuilde...
File lib/dom/scripts/databasebuilder.py (right):

http://codereview.chromium.org/10517004/diff/1/lib/dom/scripts/databasebuilde...
lib/dom/scripts/databasebuilder.py:126: for i in range(0, len(op.arguments)):
On 2012/06/04 14:43:13, antonmuhin wrote:
> it looks like for argument in op.arguments is now enough

Done.

http://codereview.chromium.org/10517004/diff/1/lib/dom/scripts/generator.py
File lib/dom/scripts/generator.py (right):

http://codereview.chromium.org/10517004/diff/1/lib/dom/scripts/generator.py#n...
lib/dom/scripts/generator.py:214: def NeedsDefaultValue(argument):
On 2012/06/04 14:43:13, antonmuhin wrote:
> maybe it should be named IsOptional?

I prefer to use a different name to emphasize the difference with top level
IsOptional (see below).

http://codereview.chromium.org/10517004/diff/1/lib/dom/scripts/generator.py#n...
lib/dom/scripts/generator.py:249: if IsOptional(operation.arguments[i]):
Current variant has lesser nesting level :)

http://codereview.chromium.org/10517004/diff/1/lib/dom/scripts/generator.py#n...
lib/dom/scripts/generator.py:250: new_operation = copy.deepcopy(operation)
On 2012/06/04 14:43:13, antonmuhin wrote:
> are you sure you need deepcopy here?

See the next statement.