Issue 10515018: Issue 3269. Warning when 'case' is not type compatible with 'switch' expression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10515018: Issue 3269. Warning when 'case' is not type compatible with 'switch' expression (Closed)

Created:
8 years, 6 months ago by scheglov

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 3269. Warning when 'case' is not type compatible with 'switch' expression http://code.google.com/p/dart/issues/detail?id=3269 R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8288

Patch Set 2 : Add valid case expression in test #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -4 lines)			Patch
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View		2 chunks	+15 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://chromiumcodereview.appspot.com/10515018/diff/1/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java File compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java (right): https://chromiumcodereview.appspot.com/10515018/diff/1/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java#newcode138 compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:138: " case 12.3: break;", It would be good ...

8 years, 6 months ago (2012-06-05 14:44:44 UTC) #2

scheglov

8 years, 6 months ago (2012-06-05 15:58:18 UTC) #3

https://chromiumcodereview.appspot.com/10515018/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
(right):

https://chromiumcodereview.appspot.com/10515018/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:138:
"    case 12.3: break;",
On 2012/06/05 14:44:44, Brian Wilkerson wrote:
> It would be good to have a valid case expression in the test.

Done.

Expand Messages | Collapse Messages

Issue 10515018: Issue 3269. Warning when 'case' is not type compatible with 'switch' expression (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add valid case expression in test #

Messages