Fix handling of long JSON messages

Fix handling of long JSON messages

Fix Debugger wire protocol for long messages.
Add a stress mode in the protocol handler to break messages
into small pieces.
Committed: https://code.google.com/p/dart/source/detail?r=8269

[siva, 2012-06-04 21:41:12]

lgtm

http://codereview.chromium.org/10515015/diff/1/runtime/bin/dbg_connection.cc
File runtime/bin/dbg_connection.cc (right):

http://codereview.chromium.org/10515015/diff/1/runtime/bin/dbg_connection.cc#...
runtime/bin/dbg_connection.cc:206: // Sending messages in short pieces can be
used to stress thest the
s/thest/test/

http://codereview.chromium.org/10515015/diff/1/runtime/bin/dbg_connection.cc#...
runtime/bin/dbg_connection.cc:224: // Wait briefly so the OS does not coalesce
message fragments.
There is another way to handle this. If you set the scoket option TCP_DELAY on
this socket then the OS will not try to coalesce message fragments and instead
will send them out instantly.

[siva, 2012-06-04 21:43:23]

http://codereview.chromium.org/10515015/diff/1/runtime/bin/dbg_connection.cc
File runtime/bin/dbg_connection.cc (right):

http://codereview.chromium.org/10515015/diff/1/runtime/bin/dbg_connection.cc#...
runtime/bin/dbg_connection.cc:224: // Wait briefly so the OS does not coalesce
message fragments.
that should be TCP_NODELAY

On 2012/06/04 21:41:12, asiva wrote:
> There is another way to handle this. If you set the scoket option TCP_DELAY on
> this socket then the OS will not try to coalesce message fragments and instead
> will send them out instantly.

[hausner, 2012-06-04 22:28:16]

Thanks Shiva.

http://codereview.chromium.org/10515015/diff/1/runtime/bin/dbg_connection.cc
File runtime/bin/dbg_connection.cc (right):

http://codereview.chromium.org/10515015/diff/1/runtime/bin/dbg_connection.cc#...
runtime/bin/dbg_connection.cc:206: // Sending messages in short pieces can be
used to stress thest the
On 2012/06/04 21:41:12, asiva wrote:
> s/thest/test/
Oops, forgot to update. Thanks.

http://codereview.chromium.org/10515015/diff/1/runtime/bin/dbg_connection.cc#...
runtime/bin/dbg_connection.cc:224: // Wait briefly so the OS does not coalesce
message fragments.
Ok good idea. But I don't want to add stuff to the platform-dependent code,
which is what I'd have to do for this.

On 2012/06/04 21:43:23, asiva wrote:
> that should be TCP_NODELAY
> 
> On 2012/06/04 21:41:12, asiva wrote:
> > There is another way to handle this. If you set the scoket option TCP_DELAY
on
> > this socket then the OS will not try to coalesce message fragments and
instead
> > will send them out instantly.
>