Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 10515012: Fix for issues 2380 and 2381 (Closed)

Created:
8 years, 6 months ago by Brian Wilkerson
Modified:
8 years, 6 months ago
Reviewers:
zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for issues 2380 and 2381 Committed: https://code.google.com/p/dart/source/detail?r=8283

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 chunk +17 lines, -0 lines 2 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/co19/co19-compiler.status View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Brian Wilkerson
8 years, 6 months ago (2012-06-04 18:29:06 UTC) #1
Brian Wilkerson
Missed a piece. PTAL.
8 years, 6 months ago (2012-06-04 18:44:19 UTC) #2
zundel
http://codereview.chromium.org/10515012/diff/4/compiler/java/com/google/dart/compiler/resolver/Resolver.java File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right): http://codereview.chromium.org/10515012/diff/4/compiler/java/com/google/dart/compiler/resolver/Resolver.java#newcode231 compiler/java/com/google/dart/compiler/resolver/Resolver.java:231: if (parameter.getQualifier() instanceof DartThisExpression) { There is also the ...
8 years, 6 months ago (2012-06-04 19:23:18 UTC) #3
Brian Wilkerson
http://codereview.chromium.org/10515012/diff/4/compiler/java/com/google/dart/compiler/resolver/Resolver.java File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right): http://codereview.chromium.org/10515012/diff/4/compiler/java/com/google/dart/compiler/resolver/Resolver.java#newcode231 compiler/java/com/google/dart/compiler/resolver/Resolver.java:231: if (parameter.getQualifier() instanceof DartThisExpression) { > There is also ...
8 years, 6 months ago (2012-06-04 19:32:39 UTC) #4
zundel
8 years, 6 months ago (2012-06-05 15:45:30 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698