RefinableTypesFinder bootstrap.

RefinableTypesFinder bootstrap.

First cut at an AST visitor that collects refinable types (with a fix to the type analyzer to flag inferred type nodes).
Committed: https://code.google.com/p/dart/source/detail?r=8307

[Brian Wilkerson, 2012-06-04 18:33:06]

LGTM

https://chromiumcodereview.appspot.com/10512012/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinderTest.java
(right):

https://chromiumcodereview.appspot.com/10512012/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinderTest.java:69:
RefinableTypesFinder finder = new RefinableTypesFinder();
Given that the types finder finds everything, couldn't the parsing, resolving
and search occur outside the for loop?

[pquitslund, 2012-06-04 21:00:12]

https://chromiumcodereview.appspot.com/10512012/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinderTest.java
(right):

https://chromiumcodereview.appspot.com/10512012/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinderTest.java:69:
RefinableTypesFinder finder = new RefinableTypesFinder();
On 2012/06/04 18:33:06, Brian Wilkerson wrote:
> Given that the types finder finds everything, couldn't the parsing, resolving
> and search occur outside the for loop?

Quite right.  Done!

[scheglov, 2012-06-05 03:27:56]

lgtm with suggestions

https://chromiumcodereview.appspot.com/10512012/diff/5001/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinder.java
(right):

https://chromiumcodereview.appspot.com/10512012/diff/5001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinder.java:68:
return type.isInferred() || type instanceof DynamicType;
Actually if it !isInferred(), then TypeAnalyzer was not able to do anything to
refine it. So, I don't think that we can do better at this level.

https://chromiumcodereview.appspot.com/10512012/diff/5001/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinderTest.java
(right):

https://chromiumcodereview.appspot.com/10512012/diff/5001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinderTest.java:33:
public class RefinableTypesFinderTest extends TestCase {
I'd like to see this based on
com.google.dart.tools.ui.refactoring.AbstractDartTest?
But we need to move it from UI tests to Core tests.
However after this you could have much easier code.

https://chromiumcodereview.appspot.com/10512012/diff/5001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinderTest.java:40:
"new Foo().foo();",
In-code indentation please.
I'd like to treat test code to be as good as production code.

https://chromiumcodereview.appspot.com/10512012/diff/5001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinderTest.java:43:
"var !1x = \"foo\";",
you could use single quote in Dart

[pquitslund, 2012-06-05 18:25:29]

Konstantin: I opted to remove the location annotations from the test source to
make it parseable.  I don't think this is a bad solution in this case.  If it
turns out to be so, we can certainly refactor...

https://chromiumcodereview.appspot.com/10512012/diff/5001/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinder.java
(right):

https://chromiumcodereview.appspot.com/10512012/diff/5001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinder.java:68:
return type.isInferred() || type instanceof DynamicType;
On 2012/06/05 03:27:56, scheglov wrote:
> Actually if it !isInferred(), then TypeAnalyzer was not able to do anything to
> refine it. So, I don't think that we can do better at this level.

Done.

https://chromiumcodereview.appspot.com/10512012/diff/5001/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinderTest.java
(right):

https://chromiumcodereview.appspot.com/10512012/diff/5001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinderTest.java:33:
public class RefinableTypesFinderTest extends TestCase {
On 2012/06/05 03:27:56, scheglov wrote:
> I'd like to see this based on
> com.google.dart.tools.ui.refactoring.AbstractDartTest?
> But we need to move it from UI tests to Core tests.
> However after this you could have much easier code.

I'm open to that (and I expect AbstractDartTest to move to a more appropriate
package as well).  Let's do that in a follow-up CL.

https://chromiumcodereview.appspot.com/10512012/diff/5001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinderTest.java:40:
"new Foo().foo();",
On 2012/06/05 03:27:56, scheglov wrote:
> In-code indentation please.
> I'd like to treat test code to be as good as production code.

Done.

https://chromiumcodereview.appspot.com/10512012/diff/5001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/RefinableTypesFinderTest.java:43:
"var !1x = \"foo\";",
On 2012/06/05 03:27:56, scheglov wrote:
> you could use single quote in Dart

Done.

[scheglov, 2012-06-05 19:18:50]

lgtm