Issue 10511010: Implement LoadVMField, StoreVMField, AllocateObjectWithBoundsCheck, InstantiateTypeArguments on ia3…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10511010: Implement LoadVMField, StoreVMField, AllocateObjectWithBoundsCheck, InstantiateTypeArguments on ia3… (Closed)

Created:
8 years, 6 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 6 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement LoadVMField, StoreVMField, AllocateObjectWithBoundsCheck, InstantiateTypeArguments on ia32. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=8251

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -14 lines)			Patch
	M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+90 lines, -10 lines	1 comment	Download
	M	runtime/vm/intermediate_language_x64.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

8 years, 6 months ago (2012-06-04 15:13:14 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/10511010/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10511010/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:539: return LocationSummary::Make(1,
Location::SameAsFirstInput());
We don't need to make input and result always the same here. Maybe add a TODO
here because what we really need is a way to specify that reusing the input as
result is allowed, but not required. (i.e. something like UsedAtStart vs
UsedUntilEnd)

Expand Messages | Collapse Messages