Issue 10510010: Get performance tests running without frog in the SDK.

Issue 10510010: Get performance tests running without frog in the SDK. (Closed)

Created:
8 years, 6 months ago by Emily Fortuna

Modified:
8 years, 6 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Get performance tests running without frog in the SDK. Committed: https://code.google.com/p/dart/source/detail?r=8309

Patch Set 4 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -67 lines)			Patch
	M	samples/third_party/dromaeo/generate_dart2js_tests.py	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
	M	tools/testing/perf_testing/run_perf_tests.py	View	1 2 3	6 chunks	+6 lines, -65 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Note -- Firefox still doesn't run with this change, but it's a start.

8 years, 6 months ago (2012-06-04 21:07:13 UTC) #1

vsm

lgtm https://chromiumcodereview.appspot.com/10510010/diff/5001/samples/third_party/dromaeo/generate_dart2js_tests.py File samples/third_party/dromaeo/generate_dart2js_tests.py (right): https://chromiumcodereview.appspot.com/10510010/diff/5001/samples/third_party/dromaeo/generate_dart2js_tests.py#newcode73 samples/third_party/dromaeo/generate_dart2js_tests.py:73: # Frog compile individual dom and html tests ...

8 years, 6 months ago (2012-06-05 19:43:29 UTC) #2

Emily Fortuna

8 years, 6 months ago (2012-06-05 22:38:16 UTC) #3

https://chromiumcodereview.appspot.com/10510010/diff/5001/samples/third_party...
File samples/third_party/dromaeo/generate_dart2js_tests.py (right):

https://chromiumcodereview.appspot.com/10510010/diff/5001/samples/third_party...
samples/third_party/dromaeo/generate_dart2js_tests.py:73: # Frog compile
individual dom and html tests into tests/frog.
On 2012/06/05 19:43:29, vsm wrote:
> Can you change this comment to:
> # Compile individual dom and html tests.
> ?

Done.

https://chromiumcodereview.appspot.com/10510010/diff/5001/tools/testing/perf_...
File tools/testing/perf_testing/run_perf_tests.py (left):

https://chromiumcodereview.appspot.com/10510010/diff/5001/tools/testing/perf_...
tools/testing/perf_testing/run_perf_tests.py:854: if browser != 'chrome' and
'dart2js' in version:
On 2012/06/05 19:43:29, vsm wrote:
> I've only validate dromaeo dart2js on chrome.  Your change will run it on
safari
> as well.   Do you know that it works?

Yeah, I tested it. It seems okay.

Expand Messages | Collapse Messages