Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 10502016: Pass in the expected number of arguments to a bailout method. (Closed)

Created:
8 years, 6 months ago by ngeoffray
Modified:
8 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Pass in the expected number of arguments to a bailout method. Committed: https://code.google.com/p/dart/source/detail?r=8323

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M lib/compiler/implementation/ssa/codegen.dart View 1 2 chunks +25 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
Unfortunately, even with this fix, the test case exceeds the call stack. Changing the bailout ...
8 years, 6 months ago (2012-06-04 16:38:54 UTC) #1
kasperl
LGTM. https://chromiumcodereview.appspot.com/10502016/diff/1/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10502016/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode2235 lib/compiler/implementation/ssa/codegen.dart:2235: // arguments it expects. This avoid the underlying ...
8 years, 6 months ago (2012-06-05 06:37:45 UTC) #2
ngeoffray
8 years, 6 months ago (2012-06-06 11:20:53 UTC) #3
Thanks Kasper

http://codereview.chromium.org/10502016/diff/1/lib/compiler/implementation/ss...
File lib/compiler/implementation/ssa/codegen.dart (right):

http://codereview.chromium.org/10502016/diff/1/lib/compiler/implementation/ss...
lib/compiler/implementation/ssa/codegen.dart:2235: // arguments it expects. This
avoid the underlying JS engine to
On 2012/06/05 06:37:45, kasperl wrote:
> This avoid ... -> This avoids having the underlying JS engine fill them in for
> us.

Done.

Powered by Google App Engine
This is Rietveld 408576698