Infer types using 'v is! Type'

Infer types using 'v is! Type'


R=brianwilkerson@google.com,messick@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=8229

[Brian Wilkerson, 2012-06-02 16:07:22]

LGTM

https://chromiumcodereview.appspot.com/10501008/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10501008/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:606: private
static boolean isExitFromFunction(DartStatement statement) {
This is another case where I think a utility method would be better implemented
as a method on DartNode. We could then use polymorphism rather than having a
sequence of "instanceof" tests and the functionality would be available to other
analyses.

https://chromiumcodereview.appspot.com/10501008/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:614: if (p
instanceof DartTryStatement) {
As I'm sure you're aware, this is incomplete. In my opinion it's good enough for
a first pass, but please add a TODO so that we don't forget that this could be
tightened up.

https://chromiumcodereview.appspot.com/10501008/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:620: // "block" is
exit is its last statement is exit
nit: second "is" --> "if"

[scheglov, 2012-06-02 16:32:56]

https://chromiumcodereview.appspot.com/10501008/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10501008/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:606: private
static boolean isExitFromFunction(DartStatement statement) {
On 2012/06/02 16:07:22, Brian Wilkerson wrote:
> This is another case where I think a utility method would be better
implemented
> as a method on DartNode. We could then use polymorphism rather than having a
> sequence of "instanceof" tests and the functionality would be available to
other
> analyses.

Hm...
I think this functionality is too specific to put it into DartNode.
And I'd not like to have too bloated API.
IMHO API should be just enough to build on it, not provide direct answers for
every request.

https://chromiumcodereview.appspot.com/10501008/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:614: if (p
instanceof DartTryStatement) {
On 2012/06/02 16:07:22, Brian Wilkerson wrote:
> As I'm sure you're aware, this is incomplete. In my opinion it's good enough
for
> a first pass, but please add a TODO so that we don't forget that this could be
> tightened up.

Done.

https://chromiumcodereview.appspot.com/10501008/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:620: // "block" is
exit is its last statement is exit
On 2012/06/02 16:07:22, Brian Wilkerson wrote:
> nit: second "is" --> "if"

Done.

[messick, 2012-06-03 20:19:01]

lgtm